fix: [M3-7251] Interface-level VPC IPv4 error in Add/Edit Linode Config dialog when VPC IPv4 checkbox is unchecked but VPC IPv4 not provided #9779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rface dropdown in Add/Edit Config dialog; casing adjustments for some variable names
… and fully fixed formatting
…g open; surface errors
…d weird spacing in Add/Edit Linode Config dialog; make noWrap on VPC IPv4 checkbox text conditional so tooltip isn't obscured
…hub.com/hana-linode/manager into M3-7121-vpc-add-config-dialog-and-table
…n the VPC IPv4 Autoassign checkbox is unchecked
|
Closing this for now but will circle back to revisit this ticket at a later time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
In the Add/Edit Linode Config drawer, for VPC interfaces, we want to mimic behavior from the Linode Create flow where if a user has unchecked the VPC IPv4 autoassign checkbox and does not provide a VPC IPv4, a field error is shown when form submission is attempted.
We have three interface slots in this dialog, so some mapping/tracking is required to present the
Must be a valid IPv4 address, e.g. 192.168.2.0error.To-Do:
Changes 🔄
Coming soon
Preview 📷
Coming soon
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply